Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elasticsearch 7.0 and Guillotina 6 #66

Merged
merged 77 commits into from
Mar 12, 2020
Merged

Conversation

masipcat
Copy link
Collaborator

@masipcat masipcat commented Feb 27, 2020

Needs this plone/guillotina#930

PR #58 and #59 can be closed after merging this

Copy link
Member

@vangheem vangheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so everything seems okay but it's a lot to take in and know the context of every change since it's a mix of forward port + a few api changes.

The api changes seem fine and everything else looks fine.

Better yet, if we can finally stabilize tests, that'd be amazing!

@codecov-io
Copy link

codecov-io commented Mar 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@df5d37c). Click here to learn what that means.
The diff coverage is 81.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   77.42%           
=========================================
  Files             ?       29           
  Lines             ?     2746           
  Branches          ?        0           
=========================================
  Hits              ?     2126           
  Misses            ?      620           
  Partials          ?        0
Impacted Files Coverage Δ
guillotina_elasticsearch/parser.py 17.39% <ø> (ø)
guillotina_elasticsearch/tests/conftest.py 100% <ø> (ø)
guillotina_elasticsearch/queries.py 100% <ø> (ø)
guillotina_elasticsearch/tests/fixtures.py 92.68% <100%> (ø)
guillotina_elasticsearch/events.py 100% <100%> (ø)
guillotina_elasticsearch/tests/test_search.py 100% <100%> (ø)
guillotina_elasticsearch/reindex.py 71.87% <100%> (ø)
...uillotina_elasticsearch/tests/test_custom_index.py 100% <100%> (ø)
guillotina_elasticsearch/tests/test_parser.py 31.25% <100%> (ø)
guillotina_elasticsearch/tests/test_vacuum.py 100% <100%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5d37c...8af23db. Read the comment docs.

@masipcat masipcat changed the title [WIP] Support Elasticsearch 7.0 and Guillotina 6 Support Elasticsearch 7.0 and Guillotina 6 Mar 10, 2020
@masipcat masipcat merged commit 9ea4194 into master Mar 12, 2020
@masipcat masipcat deleted the 3.3.x-elastic7-to-master branch March 30, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants