-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Elasticsearch 7.0 and Guillotina 6 #66
Conversation
04baf83
to
49761b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so everything seems okay but it's a lot to take in and know the context of every change since it's a mix of forward port + a few api changes.
The api changes seem fine and everything else looks fine.
Better yet, if we can finally stabilize tests, that'd be amazing!
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
Coverage ? 77.42%
=========================================
Files ? 29
Lines ? 2746
Branches ? 0
=========================================
Hits ? 2126
Misses ? 620
Partials ? 0
Continue to review full report at Codecov.
|
Needs this plone/guillotina#930
PR #58 and #59 can be closed after merging this