Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Proof of concept: Use Volto content browser #1037

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

thet
Copy link
Member

@thet thet commented Jan 11, 2021

Not working yet.

The Volto experimental PR is here: plone/volto#2112

@thet
Copy link
Member Author

thet commented Jan 11, 2021

Current status:
Trying just to import the Contents component as a first step. After fixing a number of errors and almost got a build now yarn build currently fails with this error which I do not understand yet:

thet@then:~/dev/sprints/plone6ui/REPOS/mockup$ yarn build
yarn run v1.22.10
$ run-s clean build:webpack build:docs
internal/modules/cjs/loader.js:960
  throw err;
  ^

Error: Cannot find module 'es-abstract/2020/RequireObjectCoercible'
Require stack:
- /home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/string.prototype.padend/index.js
- /home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/lib/run-task.js
- /home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/lib/run-tasks.js
- /home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/lib/index.js
- /home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/bin/run-s/main.js
- /home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/bin/common/bootstrap.js
- /home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/bin/run-s/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:957:15)
    at Function.Module._load (internal/modules/cjs/loader.js:840:27)
    at Module.require (internal/modules/cjs/loader.js:1019:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/string.prototype.padend/index.js:4:30)
    at Module._compile (internal/modules/cjs/loader.js:1133:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1153:10)
    at Module.load (internal/modules/cjs/loader.js:977:32)
    at Function.Module._load (internal/modules/cjs/loader.js:877:14)
    at Module.require (internal/modules/cjs/loader.js:1019:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/string.prototype.padend/index.js',
    '/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/lib/run-task.js',
    '/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/lib/run-tasks.js',
    '/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/lib/index.js',
    '/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/bin/run-s/main.js',
    '/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/bin/common/bootstrap.js',
    '/home/_thet/data/dev/sprints/plone6ui/REPOS/mockup/node_modules/npm-run-all/bin/run-s/index.js'
  ]
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@thet thet force-pushed the es6-thet-contentbrowser branch from 65f7de6 to f4df8d5 Compare May 23, 2021 13:42
Base automatically changed from es6 to master March 24, 2022 13:58
@petschki
Copy link
Member

Is there any progress on this anymore?

@thet
Copy link
Member Author

thet commented Dec 7, 2022

No, not yet. But it would be great if Volto would be more modular and can be reused outside. Maybe that's a sprint topic for innsbruck?

@thet
Copy link
Member Author

thet commented Sep 8, 2023

Update: This is not the right approach.
But we might be able to take up this task with @volto/client. See the discussion in: plone/volto#2112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants