Fix comparisons between different dates formats #1380
Conversation
There was a problem hiding this comment.
Hi, thanks for this! I could test your branch and can confirm, that removing a date works now correctly.
But adding a date which already exists is still allowed whether its in the RRULE or its added manually. I just quickly tried your screencasts but could not look into the code.
|
Took a closer look and now I understand: The added dates aren't checked against an RRULE but only for already added custom RDATE entries. This is ok for me because its too much overhead to check the custom date in the backend if it already exists in the RRULE. This would be much easier if we switch to a JS rrule library to check the custom dates there ... see #1210 ... but for now I'll merge. @laulaz could you backport this also to branch |
This refs #1379