Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: customizing tabular view is hard #606

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Problem: customizing tabular view is hard #606

wants to merge 4 commits into from

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Jun 22, 2021

Solution: use views for table cells such that they can be overridden

@mister-roboto
Copy link

Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

@gotcha thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@gotcha gotcha changed the title Problem: customizing tabular view is hard:w WIP Problem: customizing tabular view is hard Jun 22, 2021
@mister-roboto
Copy link

Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@gotcha gotcha changed the title WIP Problem: customizing tabular view is hard Problem: customizing tabular view is hard Jun 22, 2021
@gotcha
Copy link
Member Author

gotcha commented Jun 22, 2021

As suggested my @mauritsvanrees, I ported #595 to master.

@gotcha
Copy link
Member Author

gotcha commented Jun 22, 2021

FTR, @ThibautBorn has signed the contributor agreement and has been added to the Plone Foundation organisation.

This makes Mr.roboto complaints hard to explain.

if icon_cell_view is not None:
icon_cell_view.table_view = self
result.append(icon_cell_view())
for field in self.tabular_fields:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For collection self.tabular_fields is inherited from collection.py and a method, not a property.

@pbauer
Copy link
Member

pbauer commented Jun 23, 2021

Sorry, I don't have time to really review this. But I agree that overriding the tabular view is a pain.

@pbauer pbauer requested a review from jensens June 23, 2021 09:42
@jensens
Copy link
Member

jensens commented Jun 23, 2021

Regarding the CLA complaint: Check if the commits are containing an email address and if that address is known by GitHub (in @ThibautBorn GH settings).

@property
def type_class(self):
return ("contenttype/" +
self.table_view.normalizeString(self.context.PortalType())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You call PortalType here, but a few lines above, you use it as attribute instead of method. One is probably wrong.

I never use PortalType. I think I have only seen this sometimes in the portal_catalog.
In both cases I would use portal_type.

@mister-roboto
Copy link

Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@gotcha
Copy link
Member Author

gotcha commented Sep 15, 2023

@mauritsvanrees @jensens Would you take a last look ?

Or am I allowed to merge ?

@jensens
Copy link
Member

jensens commented Oct 5, 2023

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants