Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this a Distribution for 6.1 #8

Closed
wants to merge 1 commit into from
Closed

Conversation

jensens
Copy link
Member

@jensens jensens commented May 30, 2024

No description provided.

@mauritsvanrees
Copy link
Member

In Plone 6.1 I would not let this package depend on Products.CMFPlone, but the other way around. I have updated plone/Products.CMFPlone#3953 with some thoughts. But we could decide differently.

Also, I would not move to native namespaces at this point. I still think this is best done for all packages in Plone 7.

@jensens
Copy link
Member Author

jensens commented Jun 4, 2024

Well, I do not think we should start with the wrong direction.

-> I think we should first start with a distribution here and then make first a plan and then move templates over here.

@mauritsvanrees
Copy link
Member

I fixed a few problems on a branch. But moving this to pyproject.toml-only is not possible yet, unfortunately: it does not work with Buildout in development mode: buildout/buildout#652

And just to reiterate my point on moving to native namespaces: I am against that in Plone 6. Theoretically we could do this, but then we need to do this for all packages in the plone namespace. Otherwise if someone wants to fix a bug in another package that still uses pkg_resources-namespaces, they must first move that package to native namespaces, otherwise you cannot even install it in development mode together with already modernised packages. I really don't want that hassle in Plone 6.x.

Closing this in favour of PR #9.

@jensens
Copy link
Member Author

jensens commented Jun 19, 2024

And just to reiterate my point on moving to native namespaces: I am against that in Plone 6. Theoretically we could do this, but then we need to do this for all packages in the plone namespace. Otherwise if someone wants to fix a bug in another package that still uses pkg_resources-namespaces, they must first move that package to native namespaces, otherwise you cannot even install it in development mode together with already modernised packages. I really don't want that hassle in Plone 6.x.

FTR: Using pyproject.toml (and dropping setup.*) is not related to using native namespaces, these topics are completely unrelated.

@jensens jensens closed this Jun 19, 2024
@jensens jensens deleted the move-to-distribution branch June 19, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants