Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lower zorder traces behing some gridlines on overlayed suplots #7171

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Sep 24, 2024

Supersedes #7149.

Here is a minimal code change compared to the rather complex solution proposed in #7149 and avoids several potential side effects catch by tests.

Fixes #7144 thanks to debugging sessions with @emilykl and @gvwilson

@plotly/plotly_js
@bpostlethwaite
@stephprobst
@my-tien

@archmoj archmoj added P1 needs immediate attention bug something broken labels Sep 24, 2024
@archmoj
Copy link
Contributor Author

archmoj commented Sep 27, 2024

@my-tien and @stephprobst Please use this bundle to test this within your system and let us know.

@archmoj
Copy link
Contributor Author

archmoj commented Sep 30, 2024

@my-tien and @stephprobst Please use this bundle to test this within your system and let us know.

@stephprobst @my-tien were you able to test this bundle? https://output.circle-artifacts.com/output/job/07ec9652-70cc-4287-bfb0-c639ea6b2d39/artifacts/0/dist/plotly.min.js

@stephprobst
Copy link

@archmoj - I'm out of office and won't be able to test the package before the end of the week. Same for My-Tien.

@archmoj
Copy link
Contributor Author

archmoj commented Oct 7, 2024

Hi @stephprobst @my-tien
We are wondering if you tested this PR and zorder works as expected to possibly release a patch.
Please confirm.
Thank you!

@stephprobst
Copy link

stephprobst commented Oct 9, 2024

@archmoj: Sorry for the delay in testing. I finally got around to it.

The issue with the gridlines seems to be resolved, but we have a similar situation with the tick labels. Here is a codepen displaying the problem:

https://codepen.io/Djeramon/pen/RwzvXQX

What it looks like in the new test version:
image

From my understanding, tick labels and ticks should always be drawn on top of the traces, correct?

@stephprobst
Copy link

@archmoj: I just noticed, that there is no issue tracking this work anymore. Should I create one? Or will you take care of that? Thanks!

@archmoj archmoj merged commit de644bb into release-v2.35.3 Oct 16, 2024
1 check passed
@archmoj archmoj deleted the new-fix7144-zorder-overlay branch October 16, 2024 14:17
@archmoj
Copy link
Contributor Author

archmoj commented Oct 16, 2024

The inside tick label edge is tracked in #7227.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P1 needs immediate attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants