Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about perl in README.md #22

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Conversation

GBuella
Copy link
Contributor

@GBuella GBuella commented Jun 19, 2017

See: #5

Document in Readme.md what each dependancy is used for.
"perl -- for checking code style errors (or something similar)"


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #22   +/-   ##
====================================
  Coverage      75%   75%           
====================================
  Files          10    10           
  Lines         172   172           
  Branches       21    21           
====================================
  Hits          129   129           
  Misses         29    29           
  Partials       14    14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0505d6...9567838. Read the comment docs.

@krzycz
Copy link
Contributor

krzycz commented Jun 19, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sarahjelinek sarahjelinek merged commit df99539 into pmem:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants