-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Lingering potion & Area Effect Cloud #5276
base: minor-next
Are you sure you want to change the base?
Conversation
Nice, I'll review this tomorrow. |
Minecraft Bedrock implements AreaCloudEffect in a weird way, behaves differently than described in the wiki and in java.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is rather bloated by the EffectContainer changes so it's difficult for me to see what's going on. I've given this only a cursory review.
Co-authored-by: Dylan T. <[email protected]>
…ehaviour less surprising
Introduction
Implements lingering potions and area effect cloud + custom effect support, also complements #5163
Changes
API changes
entity\effect\EffectContainer
pocketmine\entity\object\AreaEffectCloud
pocketmine\item\LingeringPotion
SplashPotion->setLinger()
- now returnsself
instead ofvoid
Rationale for
EffectContainer
additionUnlike entities (Living) there are different types of things that can contain effects that are not necessarily applied. Such is the case of AreaEffectCloud.
Other stuff that may contain effects:
PocketMine-MP/src/item/Potion.php
Line 63 in d5762d3
Backwards compatibility
No BC-breaking changes.
Tests
https://youtu.be/cRAjwEVbb0w
This has been playtested and and there was only one issue: