Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade chevrotain for tree-shaking #288

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

CodyJasonBennett
Copy link
Member

Fixes #287. Partial revert of #284.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8dd98cb:

Sandbox Source
Vanilla Configuration

@CodyJasonBennett CodyJasonBennett merged commit 6469af6 into main Sep 20, 2023
3 checks passed
@CodyJasonBennett CodyJasonBennett deleted the fix/downgrade-chevrotain branch September 20, 2023 16:18
@github-actions
Copy link

🎉 This PR is included in version 2.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@donmccurdy
Copy link
Member

@CodyJasonBennett I think this also requires a change to the build here:

'@chevrotain/regexp-to-ast',

const inline: string[] = [
  'chevrotain',
  '@chevrotain/cst-dts-gen',
  '@chevrotain/gast',
-  '@chevrotain/regexp-to-ast',
+  'regexp-to-ast',
  '@chevrotain/types',
  '@chevrotain/utils',
  'lodash-es',
]

Will open a PR momentarily.

@CodyJasonBennett
Copy link
Member Author

@donmccurdy, thanks. It's going through now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack4 tree-shaking fail with version 2.25.1
2 participants