-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT/JDJ/resolve na undetermined failures #1453
RT/JDJ/resolve na undetermined failures #1453
Conversation
…ndetermined_fix' into RT/JDJ/resolve-na-undetermined-failures # Conflicts: # rct229/ruletest_engine/ruletest_engine.py
…ndetermined_fix' into RT/JDJ/resolve-na-undetermined-failures
…-na-undetermined-failures
This is a really impressive amount of work @JacksonJ-KC ! I'm not sure how you were able to get so much done. Quite a few had issues that were being missed. Thanks so much for documenting and repairing so many of them. I'm glad to see there's a common thread in many of them with respect to Alternatively, I could interpret an empty "results" list from the evaluate_rule as |
The empty results failure was critical to identifying some of these issues so I strongly recommend keeping that feature. |
…resolve-na-undetermined-failures
…-na-undetermined-failures
407e3ff
into
RT/JG/ruletest_na_undetermined_fix
@jugonzal07 @weilixu @yunjoonjung-PNNL This list of rule test failures and associated solutions to the failures is complete. Once the issues are all addressed and merged the CI should pass for this PR .. I would appreciate any help in knocking out the remaining issues.
1-1-e #14524-2-b #14404-11-d #14405-2-a #1442
5-2-b #1442
5-3-a #1422 (comment)
5-5-a #1422 (comment)
5-7-a #1422 (comment)
5-9-a #1422 (comment)
5-11-a #1422 (comment)
5-17-a #14605-17-b #14605-17-c #14605-28-a #14615-38-a #1462
6-2-d #1422 (comment)
6-8-d #1445
19-3-a #1455
19-3-b #1455
19-4-d #146619-10-h #145819-10-i #145819-16-a #145919-16-b #145922-8-c #1422 (comment)
22-9-c #1422 (comment)
22-17-d #1422 (comment)
22-18-c #1422 (comment)
22-19-e #1422 (comment)
22-28-c #1422 (comment)
22-33-d #1454
22-41-c #145023-4-a #1465