RS/YJ/Rule 11-7 #1526
RS/YJ/Rule 11-7 #1526
Conversation
… into RCT/YJ/get_SWH_bats_and_SWH_use
… into RCT/YJ/get_building_segment_swh_bat
…going for section 11
Indentation fix
# Conflicts: # rct229/schema/ASHRAE229.schema.json
…ace for 11-6 rule test
…-checking-tool into RS/YJ/Rule_11-6
| Parameters | ||
| ---------- | ||
| building_area_type: str | ||
| building area type of the service water heating system |
There was a problem hiding this comment.
Specify that this building_area_type is ServiceWaterHeatingSpaceOptions2019ASHRAE901
| { | ||
| "Baseline_Service_Water_Heating_System": [ | ||
| { | ||
| "building_area_type": "Automotive facility", |
There was a problem hiding this comment.
I don't think the str would be the description of the ServiceWaterHeatingSpaceOptions2019ASHRAE901, but the enums.
So for example, the Automotive facility here, should be AUTOMOTIVE_FACILITY
| ): | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
My general feeling is the RDS did not explain where the applicability/evaluation happens. The note says Applicability is determined at the building segment level, but the rule is evaluated for all SWH equipment serving the building segment. However, the logic is on swh_bat.
In that case, I suggest we use evaluate at swh_bat level.
This would require restructure of the context to only include the returned value from get_SWH_components_associated_with_each_SWH_bat. See Section5rule14 for the implementation.
There was a problem hiding this comment.
Confirmed with Karen, this rule should be evaluated at building area type level - we should update the note in the RDS to reflect this change.
…github.com/pnnl/ruleset-checking-tool into RCT/YJ/get_building_segment_swh_bat
… into RCT/YJ/get_building_segment_swh_bat
… into RCT/YJ/get_SWH_bats_and_SWH_use
…com/pnnl/ruleset-checking-tool into RCT/YJ/get_SWH_bats_and_SWH_use
… into RS/YJ/Rule_11-7
…-checking-tool into RS/YJ/Rule_11-7
This rule depends on the
get_swh_bats_and_swh_usefunction development. Hence, it isn't ready to be reviewed.