Adds command pa app permission remove, Closes #4655
#5169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @nicodecleyre! Will try to review it ASAP! |
milanholemans
requested changes
Jul 4, 2023
milanholemans
requested changes
Jul 13, 2023
nicodecleyre
force-pushed
the
pa-app-permission-remove
branch
from
c109385
to
cd28028
Compare
milanholemans
approved these changes
Aug 11, 2023
| } | ||
|
|
||
| public async commandAction(logger: Logger, args: CommandArgs): Promise<void> { | ||
| if (this.verbose) { |
There was a problem hiding this comment.
Let's move this verbose log to the method that is fired after the prompt is confirmed.
| sinon.stub(pid, 'getProcessName').returns(''); | ||
| sinon.stub(session, 'getId').returns(''); | ||
| auth.service.connected = true; | ||
| if (!auth.service.accessTokens[auth.defaultResource]) { |
There was a problem hiding this comment.
We should always clear this value when the testing has been done, so let's remove the if and clear it after running the tests.
There was a problem hiding this comment.
It's sufficient to just have 1 test where we mock the prompt confirmation to true. If it works for one option, we can assume it works for all.
There was a problem hiding this comment.
We're missing a test where we test if the prompt is actually fired.
|
Merged manually, great work adding this command! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4655