Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds command cli config list, Closes #4797 #5171

Closed
wants to merge 5 commits into from
Closed

Adds command cli config list, Closes #4797 #5171

wants to merge 5 commits into from

Conversation

nicodecleyre
Copy link
Contributor

Closes #4797

@Adam-it
Copy link
Contributor

Adam-it commented Jun 26, 2023

Thank you for your awesome work 👍 We will review it ASAP

@milanholemans milanholemans self-assigned this Jun 26, 2023
milanholemans
milanholemans requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do some adjustments before we proceed.

docs/docs/cmd/cli/config/config-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/cli/config/config-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/cli/config/config-list.mdx Outdated Show resolved Hide resolved
src/cli/Cli.spec.ts Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft June 26, 2023 22:42
@nicodecleyre nicodecleyre marked this pull request as ready for review June 29, 2023 18:58
milanholemans
milanholemans requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, we're almost there. Few more changes are needed.

docs/docs/cmd/cli/config/config-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/cli/config/config-list.mdx Show resolved Hide resolved
docs/docs/cmd/cli/config/config-list.mdx Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft July 3, 2023 22:02
@nicodecleyre nicodecleyre marked this pull request as ready for review July 7, 2023 14:48
milanholemans
milanholemans requested changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, let's do some important changes before we merge it.

docs/docs/cmd/cli/config/config-list.mdx Outdated Show resolved Hide resolved
src/m365/cli/commands/config/config-list.spec.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft July 15, 2023 19:07
@nicodecleyre nicodecleyre marked this pull request as ready for review July 30, 2023 20:45
milanholemans
milanholemans approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be merged soon.

@milanholemans
Copy link
Contributor

Merged manually, thank you for this new command! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans approved these changes

Assignees

@milanholemans milanholemans

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: cli config list
3 participants
@nicodecleyre @Adam-it @milanholemans