Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spo list roleassignment add to use util instead of calling other command, Closes #5157 #5208

Closed
wants to merge 1 commit into from
Closed

Refactor spo list roleassignment add to use util instead of calling other command, Closes #5157 #5208

wants to merge 1 commit into from

Conversation

nicodecleyre
Copy link
Contributor

Closes #5157

@nicodecleyre nicodecleyre mentioned this pull request Jul 7, 2023
Open
53 tasks
@Adam-it
Copy link
Contributor

Adam-it commented Jul 7, 2023

Thanks for another awesome PR. You rock 🤩. We will review it ASAP

@martinlingstuyl
Copy link
Contributor

Nice job @nicodecleyre! This is a good example of what we're discussing in the epic.

@plamber plamber self-requested a review July 9, 2023 05:40
@plamber plamber self-assigned this Jul 9, 2023
@plamber
Copy link
Contributor

plamber commented Jul 9, 2023

Thank you. Manually merged

@plamber plamber closed this Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamber plamber Awaiting requested review from plamber

Assignees

@plamber plamber

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor 'spo list roleassignment add' to use util instead of calling other command
4 participants
@nicodecleyre @Adam-it @martinlingstuyl @plamber