Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a new command: 'spo site admin remove'. Closes #5884 #6062

Closed
wants to merge 1 commit into from
Closed

Adds a new command: 'spo site admin remove'. Closes #5884 #6062

wants to merge 1 commit into from

Conversation

mkm17
Copy link
Contributor

@mkm17 mkm17 commented May 20, 2024

Adds a new command: 'm365 spo site admin remove'.

Closes #5884

Related tasks #5874.

Similar PR #5926

@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP!

@mkm17
Copy link
Contributor Author

mkm17 commented Jul 3, 2024

Here, the same change mentioned in this code review will be applied: using spo.getSiteId() to get the site ID in admin mode.

@Jwaegebaert
Copy link
Contributor

@mkm17, a few conflicts arose with the latest changes. Could you take a look at them?

@milanholemans milanholemans marked this pull request as draft July 9, 2024 11:18
@mkm17 mkm17 marked this pull request as ready for review July 10, 2024 14:19
@mkm17
Copy link
Contributor Author

mkm17 commented Jul 10, 2024

@Jwaegebaert thank you for the reminder, I have corrected it

@Adam-it Adam-it self-assigned this Jul 19, 2024
Adam-it
Adam-it requested changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkm17 awesome work so far 👏
I say this is in very good shape and I only added some small comments regarding code style and refactoring to remove duplicated logic.
Other than that seems like it is ready to be 🚢ed

src/m365/spo/commands/site/site-admin-remove.spec.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/site/site-admin-remove.spec.ts Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft July 20, 2024 22:23
@mkm17 mkm17 force-pushed the issues/5884_remove_admin branch 2 times, most recently from c354530 to 752f3d9 Compare July 24, 2024 19:48
@mkm17 mkm17 marked this pull request as ready for review July 24, 2024 19:53
@mkm17 mkm17 mentioned this pull request Jul 28, 2024
Closed
@mkm17 mkm17 requested a review from Adam-it July 28, 2024 15:29
Adam-it
Adam-it approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏👏👏👏

@Adam-it
Copy link
Contributor

Adam-it commented Sep 17, 2024

@mkm17 may I kindly ask you to rebase this PR against the latest main and resolve the conflicts 🙏.
After that we are ready to merge 🚀

@mkm17
Copy link
Contributor Author

mkm17 commented Sep 18, 2024

@Adam-it Ok, let me review conflicts and I will check if this command has included all changes as in spo admin site membership and spo site admin add requested by Milan in different PRs

@Adam-it
Copy link
Contributor

Adam-it commented Sep 18, 2024

@Adam-it Ok, let me review conflicts and I will check if this command has included all changes as in spo admin site membership and spo site admin add requested by Milan in different PRs

Awesome. Thanks for the update
Let's leave it for now in progress 👍

@Adam-it Adam-it marked this pull request as draft September 18, 2024 10:04
@mkm17 mkm17 marked this pull request as ready for review September 18, 2024 20:32
@mkm17
Copy link
Contributor Author

mkm17 commented Sep 18, 2024

Ok @Adam-it, I have made adjustments in both the tests and the command. Now it’s similar to the 'spo site admin add' command.

@Adam-it
Copy link
Contributor

Adam-it commented Sep 18, 2024

Ready to merge 🚀

@Adam-it
Copy link
Contributor

Adam-it commented Sep 18, 2024

Merged manually. Thank you for your awesome work 👍
You Rock 🤩

@Adam-it Adam-it closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: m365 spo site admin remove
4 participants
@mkm17 @milanholemans @Jwaegebaert @Adam-it