Fix build failure on visionOS #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sending this through. Could you please take a look at this PR for your PR: chrisvasselli#1 for the sake of passing CI |
|
thanks @chrisvasselli ! |
|
Actually I spoke too quickly, I had to undo this as it fails on Xcode 15.0 and macOS 13. Seems like |
|
@arielelkin Are you running the latest beta (beta 5)? They changed it from TARGET_OS_XR to TARGET_OS_VISION in the latest beta. No worries though, makes sense to wait till Xcode 15 comes out of beta. |
|
I’m not running the latest beta so that might be it. Unfortunately it doesn’t seem like GitHub Actions provides it just yet.
… On 3 Aug 2023, at 17:57, Chris Vasselli ***@***.***> wrote:
@arielelkin Are you running the latest beta (beta 5)? They changed it from TARGET_OS_XR to TARGET_OS_VISION in the latest beta. No worries though, makes sense to wait till Xcode 15 comes out of beta.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #212
I'm think this is the correct change, but I'm not totally sure, since I'm not totally sure how visionOS handles rendering vector graphics, and I don't see any way to get access to a recommended rasterization scale. But I tried this version (no rasterization), and rasterization with the scale hardcoded to 1x, 2x, and 3x, and you can see the results below. This me getting right up close to the window displaying the "simple - lines" demo. To my eyes, 2x, 3x, and no rasterization all look the same.
Interestingly, I see sharp lines on the no-rastering version while moving in closer to the window, but as soon as I settle it seems to render it at a 2x scale. So I think disabling rasterization may make things look better while a user is moving around?
No rastering
1x scaling
2x scaling
3x scaling