Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure user agent in utf8 encoded #111

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Ensure user agent in utf8 encoded #111

merged 2 commits into from
Aug 4, 2023

Conversation

girardof
Copy link
Contributor

@girardof girardof commented Aug 3, 2023

@girardof girardof added the bug label Aug 3, 2023
@girardof girardof requested a review from a team August 3, 2023 08:57
Base automatically changed from fg/update-regexes to develop August 3, 2023 15:13
spiderpug
spiderpug reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@spiderpug spiderpug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an example for that, or do we even have one and need to test different ruby versions?

@spiderpug spiderpug merged commit 3a6e495 into develop Aug 4, 2023
2 checks passed
@spiderpug spiderpug deleted the fg/fix-error-with-non-utf8-encoding branch August 4, 2023 07:15
@girardof girardof mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiderpug spiderpug spiderpug approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@girardof @spiderpug