This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, supplying a port to the
connect()
function is a no-op. It will always be replaced with the default port5222
becausepick_dns_answer
always returns a default port.It looks to me like the logic is reversed. If a port was explicitly supplied to
connect
then it should always be used. If not, fall back to whatever you get from thepick_dns_answer
.Feel free to close this an implement in another way if that's what you prefer.
How to repro:
Note that the port fell back to the default 5222: