Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe replace with BIP39 / A tool that can generate offline transactions for brainwallets without showing the address / WIF private key to the user.
All tools that show the user a WIF private key and Address in response to a passphrase with a single SHA256 algorithm with 0 key stretching is just asking for people to lose money.
I understand this is a key functionality of your site that is one of the main functions people use it for, but that is also the presentation at DEFCON has served as a well needed wakeup call for people relying on bad brainwallets.
Alternative solutions:
As for backwards compatibility, you could make some tool to aide in recovery.
(like https://bip32jp.github.io/english/recoverbrainwallet.html )
Thanks for the consideration.
(The pull request was more symbolic than anything, so I might have missed some stuff to delete/fix)