Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix model setting mode issue #26

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix model setting mode issue #26

merged 3 commits into from
Jul 12, 2024

Conversation

aylapear
Copy link
Member

Bug was reported that the convergence was not displaying the same in the console as the app table. Determined it was due to when glance() was being called that it was not using the model mode settings that the bisonpictools::bpt_analyse() function was using which is what was causing the variation in the outputs.

Model mode now set manually in app and then reset back to the default using on.exit().

@aylapear aylapear self-assigned this Jun 11, 2024
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a true reset in that it potentially leaves the users options altered - which can be very confusion.
A more robust method would save the current options and set those on exit.

@aylapear
Copy link
Member Author

Waiting for embr::get_analysis_mode() to be written poissonconsulting/embr#74

@aylapear aylapear requested a review from joethorley June 27, 2024 23:51
@nehill197
Copy link
Member

Used new embr::get_analysis_mode() function to reset current mb options on exit.
This ensures the glance output in the app uses the mb options of the analysis mode supplied to bpt_analyse(), to get the correct converged value.

Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good assuming that input$model_type is the analysis mode?

@aylapear aylapear merged commit 146896c into main Jul 12, 2024
1 check passed
@aylapear aylapear deleted the dev branch July 12, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants