WIP restrict screencopy modifiers #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess for optimal behavior we'll need https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/268, and something similar expressing device nodes over Pipewire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to address #75.
It seems there isn't an intersection in the modifiers for the Nvidia device and Intel device, so this still isn't working (I guess Nvidia can't render to linear buffers). Maybe it should fallback to shm, but this is potentially something that could be improved, particularly if we don't normally render the Nvidia output on the Nvidia GPU since it has Intel surfaces open...