feature/projectile-clearing #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commaster
reviewed
Dec 17, 2019
| if (projectileSync.enabled && (projectileSync.when === "always" || this.currentServer.isSSC)) { | ||
| const projectileIds = Array.from(this.currentServer.client.projectileTracking.keys()) | ||
| projectileIds.forEach(projectileId => { | ||
| if (projectileSync.type === "clear") { |
There was a problem hiding this comment.
It might be more efficient to pull this if higher, maybe even merge with the previous if.
Unless you want to, eventually, do something with the projectiles outside the clear case.
There was a problem hiding this comment.
there's another case "keep" that will be used for the opposite of clearing, which will update the server with the current client projectiles. Not sure whether this should be the default yet if not clearing.
popstarfreas
force-pushed
the
feature/projectile-clearing
branch
from
38a5df8 to
f1e139e
Compare
|
Updated for 1.4: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Release: Dimensions-v5.8.0-beta.0.zip