PSSlack threaded responses #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did some more testing and was able to get the threading to work with files. I am now able to get all response types to thread.
|
|
@devblackops Believe that this is ready to review and merge when you are ready. |
joshcorr
force-pushed
the
add-SlackMessageThreading
branch
from
841c5f2 to
0b05635
Compare
|
The Pipeline states that it is failing, but all of the pester tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is looking to add support for the feature requested in #228 for threaded responses from Poshbot with a slack backend.
Description
The quick work around is that there is a check inside the
SendMessagefunction that$Response.OriginalMessage.RawMessage.thread_tsis present. This is ran inside the Slack Backend, but could probably be put into the Response class. This change will require that this change from PSSlack be merged. RamblingCookieMonster/PSSlack#119Related Issue
#228
Motivation and Context
I was personally looking for a way to keep PoshBot messages threaded and didn't find any documentation for current support. I noticed the open issue, and thought it would be fun. This can help users cut down on noise in a channel without loosing the transparency of working with a bot.
How Has This Been Tested?
Setup a Test bot on a personal slack channel and tested threaded/Non threaded built-in, Giphy and XKCD plugin. Also tested in DMs as well. Tested various response types to ensure that text/card/url/file all respond as expected. Still having an issue with threaded file uploads.
Screenshots (if appropriate):
Previous non working state:
Any message to a thread is returned to the channel.
working state:
Keyword in thread is returned to thread. Keyword in Channel is returned to channel. Keyword in DM is only sent to DM
Types of changes
Checklist: