Max in main #61
Merged
Max in main #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is that we want those to be inline in the table, we don't want to have to fetch them via toast. It's the large records array we want toasted
rjuju
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Actually, some of the tables are now being automatically generated (there are so many datasources now), so you need to also change powa_generic_module_setup(), see https://github.com/powa-team/powa-archivist/blob/v5/powa--5.0.0dev.sql#L1356-L1357
And yes I agree that this function is really unreadable, but it still defeats copy/pasting dozen of times what's being generated.
|
Thanks a lot, merged! |
rjuju
pushed a commit
that referenced
this pull request
Apr 10, 2024
All mins_in_range and maxs_in_range should be storage main. The reason is that we want those to be inline in the table, we don't want to have to fetch them via toast. It's the large records array we want toasted.
rjuju
pushed a commit
that referenced
this pull request
Jun 15, 2024
All mins_in_range and maxs_in_range should be storage main. The reason is that we want those to be inline in the table, we don't want to have to fetch them via toast. It's the large records array we want toasted.
rjuju
pushed a commit
that referenced
this pull request
Jul 8, 2024
All mins_in_range and maxs_in_range should be storage main. The reason is that we want those to be inline in the table, we don't want to have to fetch them via toast. It's the large records array we want toasted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #60
All mins_in_range and maxs_in_range should be storage main
The reason is that we want those to be inline in the table, we don't
want to have to fetch them via toast. It's the large records array we
want toasted