Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for postgres 9.4 #69

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Remove support for postgres 9.4 #69

merged 1 commit into from
Jul 24, 2024

Conversation

rjuju
Copy link
Member

@rjuju rjuju commented Jul 24, 2024

This version has been EOL for a very long time, and supporting it just became too expensive. The main reason to drop this versions are:

  • pg_event_trigger_ddl_commands() is not there, making it impossible to detect what extension has just been created or dropped in an event trigger. Previous versions of PoWA were blindly trying to register or unregister all supported extensions when any extension is created or dropped, but that's not a sensible approach and PoWA 5 checks for the actual extension
  • Using named operators in function calls only works with the old (and not standard) syntax ":=" rather than "=>". Having to stick with the old syntax is eventually going to byte us
  • ASSERT is not supported in plpgsql. While not critical it's nice to have and adding some client-side layer doesn't make sense

This version has been EOL for a very long time, and supporting it just became
too expensive.  The main reason to drop this versions are:

- pg_event_trigger_ddl_commands() is not there, making it impossible to detect
  what extension has just been created or dropped in an event trigger.
  Previous versions of PoWA were blindly trying to register or unregister all
  supported extensions when any extension is created or dropped, but that's not
  a sensible approach and PoWA 5 checks for the actual extension
- Using named operators in function calls only works with the old (and not
  standard) syntax ":=" rather than "=>".  Having to stick with the old syntax
  is eventually going to byte us
- ASSERT is not supported in plpgsql.  While not critical it's nice to have and
  adding some client-side layer doesn't make sense
@rjuju rjuju merged commit 3917b63 into master Jul 24, 2024
9 checks passed
@rjuju rjuju deleted the pg95 branch July 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants