Fix pg_dump error on powa_module_config #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powa_modules are used for cluster-wide pg_stat datasources and do not support custom datasources. powa_modules and powa_module_functions got it right and don't have the usual "added_manually" column used to distinguish custom rows, but powa_module_functions had a wrong reference to this column. Also, powa_module_config was incorrectly created with an added_manually column, and dump was configure using it but the extension install script was incorrectly marking some of the init-time data to be custom. To fix, get rid of any mention of that column in either the table structure of the dump config. Thanks to github user guruguruguru for the report.
rjuju
force-pushed
the
fix_pmf_added_manually
branch
from
65b6d4b to
8a88d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
powa_modules are used for cluster-wide pg_stat datasources and do not support custom datasources.
powa_modules and powa_module_functions got it right and don't have the usual "added_manually" column used to distinguish custom rows, but powa_module_functions had a wrong reference to this column. Also, powa_module_config was incorrectly created with an added_manually column, and dump was configure using it but the extension install script was incorrectly marking some of the init-time data to be custom.
To fix, get rid of any mention of that column in either the table structure of the dump config.
Thanks to github user guruguruguru for the report.