Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages management fixes #224

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Messages management fixes #224

merged 1 commit into from
Nov 13, 2024

Conversation

pgiraud
Copy link
Member

@pgiraud pgiraud commented Nov 13, 2024

No description provided.

Copy link
Member

@rjuju rjuju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but could you do a single commit? both are related and needed to fix the same root issue.

In aded591, the function to add alert message has been modified
for no good reason resulting in message to be empty in the interface.

We also fix alert message management when loading data. This has been
missed when switching to VueJS. We shouldn't use "this" keyword anymore in
vue components or views.
@pgiraud pgiraud force-pushed the messages_management_fixes branch from cf4bb1d to 0410da8 Compare November 13, 2024 11:03
@pgiraud pgiraud merged commit 60afe94 into master Nov 13, 2024
1 check passed
@pgiraud pgiraud deleted the messages_management_fixes branch November 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants