Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String format #225

Merged
merged 2 commits into from
Nov 13, 2024
Merged

String format #225

merged 2 commits into from
Nov 13, 2024

Conversation

pgiraud
Copy link
Member

@pgiraud pgiraud commented Nov 13, 2024

No description provided.

@pgiraud
Avoid useless string split
aba8e72 
Before the formatting with Ruff (see commit ecb8013), some strings
were split into several lines. After the formatting the line break was
converted to an empty `" "`.

For example, the following code:
    calls = MetricDef(label="Queries per sec", type="number",
                      desc="Number of time the query has been executed, "
                            "per second")
was reformatted to:
    calls = MetricDef(
        label="Queries per sec",
        type="number",
        desc="Number of time the query has been executed, " "per second",
    )

The current commit removes the useless `" "` statements.
@pgiraud
Fix wrong formatting of string arrays
c727095 
As opposed to the previous commit, these "harmless" formatting issues
were not due to re-formatting the code with Ruff but already present
before commit ecb8013 (inverted position of quote and coma).
@pgiraud pgiraud merged commit 1da03bf into master Nov 13, 2024
1 check passed
@pgiraud pgiraud deleted the string_format branch November 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjuju rjuju rjuju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgiraud @rjuju