Skip to content

Commit

Permalink
Fix game benchmark timeout being far too low, causing skewed results
Browse files Browse the repository at this point in the history
  • Loading branch information
peppy committed Jul 3, 2023
1 parent 568c85e commit b2d1725
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion osu.Framework.Benchmarks/GameBenchmark.cs
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ public void RunSingleFrame()

public override void RunMainLoop()
{
if (!RunOnce.Wait(10000))
// This is set very high as we rely on it blocking frames from running from the background thread
// but need the look to continue to stay active until the benchmark finishes, to handle disposal.
if (!RunOnce.Wait(120000))
throw new TimeoutException("Run request didn't arrive for a long time");

RunSingleFrame();
Expand Down

0 comments on commit b2d1725

Please sign in to comment.