Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against unsupported window mode on startup #6263

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

Susko3
Copy link
Member

@Susko3 Susko3 commented Apr 22, 2024

I'd have hoped this GameHost code would guard against unsupported window modes, but this runs before the window is created so it has no effect.

windowMode.BindValueChanged(mode =>
{
if (Window == null)
return;
if (!Window.SupportedWindowModes.Contains(mode.NewValue))
windowMode.Value = Window.DefaultWindowMode;
}, true);

@bdach bdach enabled auto-merge April 23, 2024 06:15
@bdach
Copy link
Collaborator

bdach commented Apr 23, 2024

@peppy this pull (or #6264, if it gets merged, I guess) must make it into a framework package before we do a game release.

@bdach bdach merged commit 2e6cced into ppy:master Apr 23, 2024
20 of 21 checks passed
@Susko3 Susko3 deleted the guard-against-unsupported-windowmode branch April 23, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platforms other than Windows crash when last windowed mode is borderless in latest master
2 participants