Update dropdown on store page #11534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
requested changes
Oct 8, 2024
| &__label { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| margin: 0; | ||
| color: var(--label-colour); | ||
| font-size: @font-size--normal; | ||
| padding: var(--label-padding-base) var(--input-padding-base) 0; | ||
| padding: 5px var(--input-padding-base) 0; | ||
| position: absolute; |
There was a problem hiding this comment.
can do with a comment on why it's position: absolute, also a note for the sizing of --label-height (or calculate it instead?)
notbakaneko
reviewed
Oct 8, 2024
| @@ -3,7 +3,9 @@ | |||
|
|
|||
| .input-container { | |||
| --label-font-size: @font-size--normal; | |||
| --label-height: calc(var(--label-font-size) + var(--input-padding-base) + 5px); | |||
| --label-height: calc( | |||
There was a problem hiding this comment.
I think this should be font-size * 1.25 (the line-height) + padding base tbh 🤔
notbakaneko
previously approved these changes
Oct 8, 2024
|
wait no, that was with wrong padding - it should be 5px both sides |
|
wut |
notbakaneko
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hack involving floating the label is involved 🔧