Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contains method with StringComparison parameter. #1208

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

microspaze
Copy link

@microspaze microspaze commented Jan 16, 2024

Modified from older commit: 9040c0b

Remove useless Contains extension method and fix args unmatch bug.

@praeclarum
Copy link
Owner

Hello, thank you very much. I wonder if you wouldn't mind splitting this PR into two: one with your DefaultValue change (which needs some tests) and the comparison changes. I like your code, for the StringComparison :-)

@microspaze
Copy link
Author

@praeclarum I have revert the commit of DefaultValue on my master branch. Now the merge request is clean. Please verify
when you are convenient. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants