-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix comment #502
base: master
Are you sure you want to change the base?
fix comment #502
Conversation
Signed-off-by: hw_3333 <[email protected]>
Codecov ReportBase: 85.05% // Head: 85.05% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #502 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 12 12
Lines 1606 1606
=======================================
Hits 1366 1366
Misses 155 155
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@hwcyy e2e tests are failing because there is a CRD change. Could you please generate the CRDs as well? |
Signed-off-by: hw_3333 <[email protected]>
fixed ! |
@hwcyy could you please update the crds in https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/zookeeper.pravega.io_zookeeperclusters_crd.yaml |
@hwcyy could you please make the change? |
Signed-off-by: hw_3333 [email protected]
Change log description
fix comment
Purpose of the change
fix comment
What the code does
fix comment
How to verify it