Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment #502

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix comment #502

wants to merge 2 commits into from

Conversation

hwcyy
Copy link

@hwcyy hwcyy commented Oct 9, 2022

Signed-off-by: hw_3333 [email protected]

Change log description

fix comment

Purpose of the change

fix comment

What the code does

fix comment

How to verify it

Signed-off-by: hw_3333 <[email protected]>
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 85.05% // Head: 85.05% // No change to project coverage 👍

Coverage data is based on head (1b4e31b) compared to base (ed16dab).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          12       12           
  Lines        1606     1606           
=======================================
  Hits         1366     1366           
  Misses        155      155           
  Partials       85       85           
Impacted Files Coverage Δ
api/v1beta1/status.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hwcyy hwcyy closed this Oct 10, 2022
@hwcyy hwcyy reopened this Oct 10, 2022
@hwcyy hwcyy closed this Oct 10, 2022
@hwcyy hwcyy reopened this Oct 10, 2022
@anishakj
Copy link
Contributor

@hwcyy e2e tests are failing because there is a CRD change. Could you please generate the CRDs as well?

Signed-off-by: hw_3333 <[email protected]>
@hwcyy
Copy link
Author

hwcyy commented Oct 10, 2022

@hwcyy e2e tests are failing because there is a CRD change. Could you please generate the CRDs as well?

fixed !

@anishakj
Copy link
Contributor

@anishakj
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants