Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kub libs #568

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Bump kub libs #568

merged 2 commits into from
Dec 11, 2023

Conversation

AKamyshnikova
Copy link
Contributor

@AKamyshnikova AKamyshnikova commented Sep 4, 2023

Signed-off-by: Ann Taraday [email protected]

Change-Id: Ia673486d8ebb3c76e86d1cc3af846cd890b4ffaa

Change log description

  • k8s libs to v0.27.5
  • controller-runtime to v0.15.0

Updated usage for fake client - now required WithStatusSubresource(..)

Purpose of the change

Fixes: #567

What the code does

(Detailed description of the code changes)

How to verify it

All e2e tests should pass

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28d1f69) 85.12% compared to head (1159ce0) 85.12%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          12       12           
  Lines        1613     1613           
=======================================
  Hits         1373     1373           
  Misses        155      155           
  Partials       85       85           
Files Coverage Δ
api/v1beta1/zookeepercluster_types.go 98.80% <ø> (ø)
controllers/zookeepercluster_controller.go 65.46% <100.00%> (ø)
pkg/yamlexporter/exportutil.go 61.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AKamyshnikova AKamyshnikova force-pushed the k8s-libs-27.5 branch 2 times, most recently from 3d2068f to 18597b9 Compare September 5, 2023 13:16
@AKamyshnikova
Copy link
Contributor Author

Run e2e tests locally and they passed

• [SLOW TEST:585.533 seconds]
Perform rolling restart on zk cluster
/root/zookeeper-operator/test/e2e/rolling_restart_test.go:20
  Check rolling restart operation
  /root/zookeeper-operator/test/e2e/rolling_restart_test.go:21
    should perform rolling restart
    /root/zookeeper-operator/test/e2e/rolling_restart_test.go:22
------------------------------
STEP: tearing down the test environment

Ran 8 of 8 Specs in 3469.747 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAPIs (3469.75s)
PASS
ok      github.com/pravega/zookeeper-operator/test/e2e  3469.779s
make undeploy

@anishakj
Copy link
Contributor

anishakj commented Sep 8, 2023

Run e2e tests locally and they passed

• [SLOW TEST:585.533 seconds]
Perform rolling restart on zk cluster
/root/zookeeper-operator/test/e2e/rolling_restart_test.go:20
  Check rolling restart operation
  /root/zookeeper-operator/test/e2e/rolling_restart_test.go:21
    should perform rolling restart
    /root/zookeeper-operator/test/e2e/rolling_restart_test.go:22
------------------------------
STEP: tearing down the test environment

Ran 8 of 8 Specs in 3469.747 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAPIs (3469.75s)
PASS
ok      github.com/pravega/zookeeper-operator/test/e2e  3469.779s
make undeploy

@AKamyshnikova could you please check if there is change in CRD file generated? If there is change please check in the CRD file too

@AKamyshnikova AKamyshnikova force-pushed the k8s-libs-27.5 branch 2 times, most recently from 182bf3d to fb0ad2b Compare September 8, 2023 09:57
@AKamyshnikova
Copy link
Contributor Author

@anishakj Thanks for pointing this! Updated CRDs

@anishakj
Copy link
Contributor

@AKamyshnikova Could you please resolve conflicts?

- k8s libs to v0.27.5
- controller-runtime to v0.15.0

Updated usage for fake client - now required WithStatusSubresource(..)
MultiNamespacedCacheBuilder is deprecated switched to usage
Cache.Options.Namespaces.
Updated usage for depricated wait.Poll and use
fake.NewClientBuilder()

Fixes: pravega#567

Signed-off-by: Ann Taraday <[email protected]>

Change-Id: Ia673486d8ebb3c76e86d1cc3af846cd890b4ffaa
Signed-off-by: Ann Taraday <[email protected]>

Change-Id: I2fafe2a37bc3392e0db4cf20879567b690a2aa4c
@anishakj anishakj merged commit b1524f2 into pravega:master Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for kub libs v0.27
2 participants