Issue 572: Enable external option to client service #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: idolaman <[email protected]>
Signed-off-by: idolaman <[email protected]>
Signed-off-by: idolaman <[email protected]>
Signed-off-by: idolaman <[email protected]>
Signed-off-by: idolaman <[email protected]>
idolaman
force-pushed
the
external-option-client-service
branch
from
9df5502
to
2ca1a87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 85.12% 85.13% +0.01%
==========================================
Files 12 12
Lines 1613 1615 +2
==========================================
+ Hits 1373 1375 +2
Misses 155 155
Partials 85 85 ☔ View full report in Codecov by Sentry. |
|
@anishakj can you check this out? This is a quite needed feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Adds the option to use external ZooKeeper in
ClientServicePurpose of the change
Fixes #572
What the code does
The code uses the same logic as AdminServerService boolean external field. in ClientService, to expose client-service outside
the cluster, using LoadBalancer service type.
How to verify it
System tests must pass, when clientService.external is true, client service in kubernetes type needs to be LoadBalancer (this test added).