-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enables stream to pull new items when the before_attribute has been deleted #18
Conversation
I can't remember why this was different than the main PRAW. If I remember correctly, I had issues with tests passing without the change. I will do some digging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a change log entry?
Updated. |
Could you take a look at the check errors? It seems some cassettes need re-recorded with this change. |
Hi @LilSpazJoekp and @cmays90, any ETA on when this fix will be merged into asyncpraw? I recently switched from PRAW and I'm facing the exact same issue described in #16 where a subreddit stream just stops working after a little while, no exceptions/errors logged. I was thinking of installing this PR directly but I see some failing checks - would that be a problem? Thank you for all your work. |
Most likely not. However, since tests are not currently passing, I cannot guarantee its stability. Though, looking at the failing tests, it appears it just needs the tests rerecorded. That being said, you are more than welcome to use this version however, I won't accept any new issues regarding said version. |
@cmays90 Could you add yourself to AUTHORS.rst please? After that, I'll finish this up for you. Thanks! |
…te has been deleted
Signed-off-by: LilSpazJoekp <[email protected]>
I got this finished up and merged for you. Thanks for the PR! |
Pull Request Test Coverage Report for Build af4d1a1a91dfc32f80de9d933bdda370aafcf180-PR-18
💛 - Coveralls |
Fixes #16
Feature Summary and Justification
This feature fixes an issue where the stream would stall when the last item pulled was deleted. This fix matches the functionality and implementation of main PRAW.