Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enables stream to pull new items when the before_attribute has been deleted #18

Merged
merged 3 commits into from
Jan 25, 2021
Merged

fix: enables stream to pull new items when the before_attribute has been deleted #18

merged 3 commits into from
Jan 25, 2021

Conversation

cmays90
Copy link
Contributor

@cmays90 cmays90 commented Nov 27, 2020

Fixes #16

Feature Summary and Justification

This feature fixes an issue where the stream would stall when the last item pulled was deleted. This fix matches the functionality and implementation of main PRAW.

@LilSpazJoekp
Copy link
Member

I can't remember why this was different than the main PRAW. If I remember correctly, I had issues with tests passing without the change. I will do some digging.

Copy link
Member

@LilSpazJoekp LilSpazJoekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a change log entry?

@cmays90
Copy link
Contributor Author

cmays90 commented Nov 27, 2020

Updated.

@LilSpazJoekp
Copy link
Member

LilSpazJoekp commented Nov 27, 2020

Could you take a look at the check errors? It seems some cassettes need re-recorded with this change.

@vikasbhatia
Copy link

Hi @LilSpazJoekp and @cmays90, any ETA on when this fix will be merged into asyncpraw? I recently switched from PRAW and I'm facing the exact same issue described in #16 where a subreddit stream just stops working after a little while, no exceptions/errors logged.

I was thinking of installing this PR directly but I see some failing checks - would that be a problem?

Thank you for all your work.

@LilSpazJoekp
Copy link
Member

I was thinking of installing this PR directly but I see some failing checks - would that be a problem?

Most likely not. However, since tests are not currently passing, I cannot guarantee its stability. Though, looking at the failing tests, it appears it just needs the tests rerecorded. That being said, you are more than welcome to use this version however, I won't accept any new issues regarding said version.

@LilSpazJoekp
Copy link
Member

@cmays90 Could you add yourself to AUTHORS.rst please? After that, I'll finish this up for you. Thanks!

@LilSpazJoekp LilSpazJoekp added the Bug Something isn't working label Jan 18, 2021
@LilSpazJoekp LilSpazJoekp merged commit 3969518 into praw-dev:master Jan 25, 2021
@LilSpazJoekp
Copy link
Member

I got this finished up and merged for you. Thanks for the PR!

@coveralls
Copy link

Pull Request Test Coverage Report for Build af4d1a1a91dfc32f80de9d933bdda370aafcf180-PR-18

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build faebf274c697b55fadff2dbd2012351e07a107b8: 0.0%
Covered Lines: 3559
Relevant Lines: 3559

💛 - Coveralls

@rustom rustom mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subreddit.stream.submissions() stops after an hour or so
4 participants