Merge pull request #1664 from LilSpazJoekp/master

Broaden exception catch for async check
praw-dev · Feb 7, 2021 · 68ef2de · 68ef2de
2 parents 1453036 + fc3af25
commit 68ef2de
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,6 +4,10 @@ Change Log
 Unreleased
 ----------
 
+**Fixed**
+
+* Asynchronous check will no longer fail in Python 3.6 multithreading edge cases.
+
 7.1.3 (2021/02/05)
 ------------------
 

diff --git a/praw/reddit.py b/praw/reddit.py
@@ -375,14 +375,14 @@ def _check_for_async(self):
             except NameError:
                 pass
             in_async = False
-            if sys.version_info >= (3, 7, 0):
-                try:
+            try:
+                if sys.version_info >= (3, 7, 0):
                     asyncio.get_running_loop()
                     in_async = True
-                except RuntimeError:
-                    pass
-            else:
-                in_async = asyncio.get_event_loop().is_running()
+                else:
+                    in_async = asyncio.get_event_loop().is_running()
+            except Exception:  # Quietly fail if any exception occurs during the check
+                pass
             if in_async:
                 logger.warning(
                     "It appears that you are using PRAW in an asynchronous"