Prefer usage of npm_config_target and npm_config_runtime
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a similar problem that was acknowledged by #46 a few years ago, and which I raised a few months back, #78.
The issue is that
node-gyp-builddoesn't acknowledge the use of standardizednpm_config_*variables, and instead relies on values likeprocess.versions.moduleandprocess.versions.electronwhich are not easily configurable as they are read-only.This PR does two things:
runtimeto be set to"electron"ifprocess.env.npm_config_runtimeis equal to"electron".abiif an explicitprocess.env.npm_config_targetis defined ("electron","node", and"node-webkit"are already valid values that can be passed tonodeAbi.getAbito determine the abi).I'm not sure if there are design reasons you have to keep things the way they are, but please let me know. Also happy to adjust the PR if you'd prefer to have this issue solved in a different way.
process.versions.nodeis still preferred overprocess.env.npm_config_target, for example, as I wanted to limit the scope to address my earlier Github issue.Thank you!