Added list of exported metrics #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jppgks
approved these changes
Jan 24, 2024
tgaddair
reviewed
Jan 25, 2024
| @@ -163,13 +162,56 @@ print("Response:", resp[0].choices[0].message.content) | |||
|
|
|||
| See [OpenAI Compatible API](https://predibase.github.io/lorax/guides/openai_api) for details. | |||
|
|
|||
| ### Metrics | |||
There was a problem hiding this comment.
Can you add this to docs instead? We have a section called Reference, we could add a page called Prometheus Metrics or similar.
There was a problem hiding this comment.
Also, is this something we can expose via the openapi.json?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a list of the exported metrics to the readme.
Further info would be nice to add to the table - such as the metric type and the description.