Batch prefill tokens uses max input tokens as default #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Mar 11, 2024
| // Set default values dervided from other args | ||
|
|
||
| // If the value of max_batch_prefill_tokens is not specified, default to max_input_length | ||
| if args.max_batch_prefill_tokens.is_none() { |
There was a problem hiding this comment.
Can we follow the same convention used by max_batch_total_tokens, which is also optional?
|
@noyoshi how we looking here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_batch_prefill_tokensis now optional, and it is defaulting to the value frommax_input_length.Now, users can define custom
max_input_lengthwithout having to also specifymax_batch_prefill_tokens