-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if update_data contains update before batch_update #316
base: main
Are you sure you want to change the base?
Conversation
# Also: Remove the showspikes from the layout, otherwise the autorange | ||
# will not work as intended (it will not be triggered again) | ||
# Note: this removal causes a second trigger of this method | ||
# which will go in the "else" part below. | ||
for xaxis_str in self._xaxis_list: | ||
self.layout[xaxis_str].pop("showspikes") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure whether this is necessary when update_data
is NoUpdate
(In the previous logic, this would be executed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite sure it is correct to only execute this code if update_data is a proper update.
plotly_resampler/figure_resampler/figure_resampler_interface.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 96.49% 92.38% -4.12%
==========================================
Files 14 13 -1
Lines 1141 1129 -12
==========================================
- Hits 1101 1043 -58
- Misses 40 86 +46 ☔ View full report in Codecov by Sentry. |
When using
FigureWidgetResampler
using traces that are not resampled (e.g., Histogram, Bar, etc.), the following action chain resulted in aTypeError
(becauseupdate_data
is NoUpdate)Reproducible code:
Error ⬇️