-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ vectorized feature function support #58
Conversation
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 98.03% 96.28% -1.76%
==========================================
Files 23 23
Lines 1070 1103 +33
==========================================
+ Hits 1049 1062 +13
- Misses 21 41 +20
Continue to review full report at Codecov.
|
This PR opens the path to supporting functions that require to see all the data in a fixed format (nb. windows, window-size); e.g. sklearn-like transforms (see #56 ) |
Benchmarking ✔️ (see predict-idlab/tsflex-benchmarking#4) |
@jonasvdd ready for review! 😄 |
Maybe also update the poetry lock? (to fix dependabot alerts) |
… into vectorized_features
LGTM! very nice work 💪🏼 |
Other dependencies have not updated this yet (which blocks us to update it) |
Other dependencies have not yet updated their dependency on protobuf (resulting in poetry not updating this automatically).. I'll merge the PR as all other TODOs are ✔️ and leave this open for a future PR! Thx for the review 😄 |
TODOs: