Use ^\s*```$ for mkdCodeEnd #522
Conversation
| @@ -819,7 +819,7 @@ function! s:MarkdownHighlightSources(force) | |||
| else | |||
| let include = '@' . toupper(filetype) | |||
| endif | |||
| let command = 'syntax region %s matchgroup=%s start="^\s*```\s*%s.*$" matchgroup=%s end="\s*```$" keepend contains=%s%s' | |||
| let command = 'syntax region %s matchgroup=%s start="^\s*```\s*%s.*$" matchgroup=%s end="^\s*```$" keepend contains=%s%s' | |||
There was a problem hiding this comment.
Could you rebase this to the latest commit? #534 made some changes to this line.
There was a problem hiding this comment.
What about situations such as code blocks in block quotes? This is valid markdown in many/most parsers is it not?
> This is a block quote with a nested code block
>
> ```lua
> local example = "foo"
> ```
>
> Rest of block quote.I'm a little confused why this example doesn't seem to be broken prior to this PR. The GitHub highlighting is off, but in VIM the whole thing is just a block quote. Are we not catching those at all? And it does seem there is something else wrong because this paragraph after the blockquote is not the same syntax group as the top one in this comment...
It's a bug in |
Some languages use markdown style fenced code block for documenting examples. Current pattern for mkdCodeEnd breaks that.
Current:
Fixed:
