Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant local variables #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove redundant local variables #84

wants to merge 1 commit into from

Conversation

dnskr
Copy link

@dnskr dnskr commented Apr 24, 2024

Minor code style improvements.

@dnskr dnskr requested a review from a team as a code owner April 24, 2024 19:30
@dnskr dnskr requested a review from presto-oss April 24, 2024 19:30
elharo
elharo suggested changes Apr 29, 2024
View reviewed changes
Copy link

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like redundant local variables. They make reading and debugging the code easier.

@dnskr
Copy link
Author

dnskr commented Apr 30, 2024

I like redundant local variables. They make reading and debugging the code easier.

I agree it might be more convenient to debug with local variables, but not sure about reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo requested changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnskr @elharo