Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parquet] Use deterministic data in parquet.batchreader.decoders.TestValuesDecoders #23840

Open
ZacBlanco opened this issue Oct 15, 2024 · 1 comment · May be fixed by #23956
Open

[parquet] Use deterministic data in parquet.batchreader.decoders.TestValuesDecoders #23840

ZacBlanco opened this issue Oct 15, 2024 · 1 comment · May be fixed by #23956
Labels
beginner-task flaky-test good first issue jumpstart

Comments

@ZacBlanco
Copy link
Contributor

Currently, all of these tests utilize randomness to generate page data for decoder verification. This can introduce test flakiness.

We should re-write these tests to use a deterministic set of values which encompasses the possible edge cases but prevents test failures
@ZacBlanco ZacBlanco mentioned this issue Oct 15, 2024
Merged
6 tasks
@ges1227
Copy link

ges1227 commented Nov 6, 2024

About to work on that issue.

ges1227 added a commit to ges1227/presto that referenced this issue Nov 6, 2024
@ges1227
Replace random test values by discrete ones
89ba2ab 
The use of Random() function in the parquet.batchreader.decoders tests may cause flakiness.

Adds TestMode.java to parameterize tests with an arbitrary value and an upper-/lower-bounded value.

Resolves: prestodb#23840
@ges1227 ges1227 linked a pull request Nov 6, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-task flaky-test good first issue jumpstart
Projects
Build, releases and testing
Status: 🆕 Unprioritized
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace random test values by discrete ones ges1227/presto
3 participants
@elharo @ZacBlanco @ges1227