Replace random test values by discrete ones #23956
Open
+136
−94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds TestMode.java to parameterize tests with an arbitrary value and an upper-/lower-bounded value.
Used upper and lower bounds of the previously used Random.getInt()/Random.getLong() functions. Although before the lower bound with Random.getInt()/Random.getLong() was 0 it was lowered to the most negative values for the datatype where possible.
com/facebook/presto/parquet/batchreader/decoders/TestParquetUtils.java
the valueString in line112 was randomly chosen. This might deserve more attention on code review.Motivation and Context
The use of Random() function in the parquet.batchreader.decoders tests may cause flakiness.
Resolves: #23840
Impact
Developer level: Reduced flakiness in test.
Test Plan
CI should run.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.