[native] Add proxygen endpoint for expression evaluation #22927
Conversation
pramodsatya
changed the title
pramodsatya
force-pushed
the
expr_endpt
branch
2 times, most recently
from
822f79f
to
2352cd4
Compare
There was a problem hiding this comment.
@pramodsatya : Have done a first round of comments. Will read your tests more closely once you address the comments here.
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.h
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.h
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.h
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Show resolved
Hide resolved
| functions::prestosql::registerAllScalarFunctions("presto.default."); | ||
| exec::registerFunctionCallToSpecialForms(); | ||
|
|
||
| auto httpServer = std::make_unique<http::HttpServer>( |
There was a problem hiding this comment.
You can test RowExpressionEvaluator without all this http stubing if abstracting as suggested. That is cleaner.
There was a problem hiding this comment.
Could you please share how to get rid of this http stubbing? I wasn't quite able to follow how it can be refactored.
pramodsatya
force-pushed
the
expr_endpt
branch
from
2352cd4
to
496bbc5
Compare
There was a problem hiding this comment.
Thanks for the feedback @aditi-pandit, addressed the comments. Could you please take another look?
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Outdated
Show resolved
Hide resolved
| void RowExpressionEvaluator::evaluateExpression( | ||
| const std::vector<std::unique_ptr<folly::IOBuf>>& body, | ||
| proxygen::ResponseHandler* downstream) { | ||
| try { |
There was a problem hiding this comment.
Thanks for the suggestion, added helper functions and updated accordingly. I could not find a similar utility function in the codebase. Could you please take another look?
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp
Outdated
Show resolved
Hide resolved
| functions::prestosql::registerAllScalarFunctions("presto.default."); | ||
| exec::registerFunctionCallToSpecialForms(); | ||
|
|
||
| auto httpServer = std::make_unique<http::HttpServer>( |
There was a problem hiding this comment.
Could you please share how to get rid of this http stubbing? I wasn't quite able to follow how it can be refactored.
pramodsatya
force-pushed
the
expr_endpt
branch
from
496bbc5
to
d9c3dcd
Compare
pramodsatya
force-pushed
the
expr_endpt
branch
from
d9c3dcd
to
e19ae51
Compare
pramodsatya
force-pushed
the
expr_endpt
branch
from
e19ae51
to
747ef08
Compare
Adds proxygen endpoint for expression evaluation in the native sidecar, the
expression is delegated to the sidecar by changes in #23331 .
Depends on facebookincubator/velox#10657 .