Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-deterministic tests #23120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove non-deterministic tests #23120

wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jul 2, 2024

Description

Fixes #23119

Motivation and Context

These tests are fundamentally timing dependent and non-deterministic.

Impact

none

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo requested a review from tdcmeehan July 2, 2024 17:46
@elharo elharo marked this pull request as ready for review July 2, 2024 22:18
@elharo elharo requested a review from a team as a code owner July 2, 2024 22:18
@elharo elharo requested a review from presto-oss July 2, 2024 22:18
@tdcmeehan
Copy link
Contributor

#19675 fixes this by removing the non-determinism, let me see if I can get that done soon. Although this test is dependent on the environment, which we know can lead to flakiness, I don't want to delete it outright because the thing it tests is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestResourceManagerClusterStatusSender.testNodeStatus is flaky
2 participants