Added catalog and schema level access checks in USE statement #23882
+225
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What happens if the user tries to query Presto, but they set the default catalog to something they don't have permission for? For example, if they load up the Presto CLI with the |
|
@tdcmeehan , The moment the user runs a query involving the restricted catalog, Presto will attempt to access it, triggering a permissions check. If permissions are lacking, Presto immediately returns an error, something like In the below example user "newuser" is restricted to catalog "tpcds" 
|
|
The commit message needs to be reworked. Perhaps just use the PR title as the commit message, but use the present tense and imperative mood. |
|
I have updated the commit message. Please check |
tdcmeehan
approved these changes
Nov 6, 2024
|
FYI I started seeing actions failures in Details
@annmegha could you investigate? |
|
Strangely, it seems this test wasn't even executed until after the merge. I've opened the revert at #23965. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added catalog and schema level access checks when a user tries USE statement
Motivation and Context
A user with any role who has not been granted access to a specific catalog or schema is still able to execute the USE command. The expected behavior is that such users should receive an "Access Denied" error when attempting to access a catalog or schema for which they lack permission.
Refer : #23881
Test Plan
Added the related testcases to the code change
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.