Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging of Hive catalog configuration properties #23900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denodo-research-labs
Copy link
Contributor

Description

Enable logging of Hive catalog configuration properties so that users can check it in Presto logs.

Motivation and Context

Consistency, since the other types of catalogs logs their configuration properties.

Pull request #13070 disabled several Hive logs, including the configuration properties, to avoid hitting the max log size in Travis. Now Travis is not longer used.

Contributor checklist

Release Notes

Please follow release notes guidelines and fill in the release notes below.

If release note is NOT required, use:

== NO RELEASE NOTE ==

@tdcmeehan
Copy link
Contributor

While we don't use Travis, we do try to avoid spamming the logs. Can you try to make this configurable? You should be able to extract a property from the config object, and conditionally remove the quiet() method based on it.

@denodo-research-labs
Copy link
Contributor Author

Ok, but why this difference with the other connectors like Iceberg, Delta, etc? Is it because Hive is the connector with the highest number of tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants